1. 17 May, 2022 4 commits
  2. 16 May, 2022 2 commits
  3. 13 May, 2022 1 commit
  4. 12 May, 2022 1 commit
    • Pierre Smits's avatar
      Fixed: Quote Edit - wrong decorator screen used (OFBIZ-12554) (#497) · 7177fea6
      Pierre Smits authored
      Currently, the EditQuote screen in QuoteScreens.xml is using 'main-decorator' as the decorator-screen reference screen.
      Because of this, the menus for the quote (being edited) are not shown to the user.
      
      modified: QuoteScreens.xml
      changed decorator-screen ref in screen EditQuote from 'main-decorator' to 'CommonQuoteDecorator
      7177fea6
  5. 10 May, 2022 1 commit
  6. 06 May, 2022 1 commit
    • Gil Portenseigne's avatar
      Improved: Update sshd dependency and implementation (OFBIZ-12612) · edf58cfb
      Gil Portenseigne authored
      This commit fix an issue that, under high usage, redondant thread are
      created.
      Update sshd-core to 2.8.0, adding sshd-ftp since it has been separated in its own library.
      Add SshClientHelper to hold the unique instance of SshClient.
      Update SshFtpClient class to use the unique SshClient, manage the password/identity into the session and clean close the session.
      edf58cfb
  7. 05 May, 2022 1 commit
  8. 04 May, 2022 3 commits
    • Pierre Smits's avatar
      Fixed: GlSetupScreens.xml - MainActionMenu not shown (OFBIZ-12559) (#507) · 4caa0dce
      Pierre Smits authored
      The MainActionMenu of the Accounting component is
      intended to provide the users with CREATE permissions
      a direct way to create the main objects of the
      Accounting components (Gl transaction, invoice,
      payment), instead of - as such a user - have to go
      through multiple screens to get to the action
      trigger to create such objects.
      The MainActionMenu is applied in various decorator
      screens. It is, however, not applied in the
      GlSetupScreen.xml file.
      
      Modified: GlSetupScreens.xml
      added pre-body decorator section, including ref to
      MainActionMenu, to:
      - screen ListCompanies
      - screen AddCompany
      - screen ImportExport
      4caa0dce
    • Pierre Smits's avatar
      Fixed: Party Main: duplicate action trigger (Person/Group) (OFBIZ-12560) (#508) · 6244ad93
      Pierre Smits authored
      When accessing
      https://localhost:8443/partymgr/control/main the
      screen shows duplicate action triggers for the
      creation of a new party of type=PERSON or
      of type=PARTYGROUP.
      These action triggers come from the MainActionMenu
      for the a component, and from the 'CreateNewParty'
      menu.
      
      modified: PartyMenus.xml
      removed from menu CreateNewParty:
      - menu-item for the creation of a PartyGroup
      - menu-item for the creation of a Person
      as these already exists in the MainActionMenu of
      the component.
      6244ad93
    • Jacques Le Roux's avatar
      Improved: Fix some bugs Spotbugs reports (OFBIZ-12386) · 8d8b66aa
      Jacques Le Roux authored
      Renames SecuredUpload::isValidFile to isValidFileName
      8d8b66aa
  9. 03 May, 2022 1 commit
    • Jacques Le Roux's avatar
      Fixed: ProductWorker getBoolean logic update (OFBIZ-12609) · 7c9d583e
      Jacques Le Roux authored
      If chargeShipping is null (default) the method ProductWorker.shippingApplies
      fails.
      GenericEntity::getBoolean has changed. If the passed value equals null, false is
      returned. ProductWorker expects "null".
      
      jleroux: GenericEntity::getBoolean has been changed for OFBIZ-12386 "Fix some
      bugs SpotBugs reports". I checked at least that
      "CommunicationEventServices::sendEmailToContactList handles correctly
      tmpResult != null". After this fix I have to check other possible similar cases
      I neglected. Fortunately, only trunk is concerned.
      
      Thanks: Ingo Wolfmayr
      7c9d583e
  10. 25 Apr, 2022 2 commits
  11. 24 Apr, 2022 2 commits
  12. 22 Apr, 2022 6 commits
  13. 21 Apr, 2022 2 commits
  14. 20 Apr, 2022 1 commit
    • Jacques Le Roux's avatar
      Fixed: XML Import fails due to security check (OFBIZ-12602) · 3de52be9
      Jacques Le Roux authored
      When importing an entity with "${" in for at least an element it's rejected
      because of the security check done to protect from Freemarker unauth attacks
      (see OFBIZ-12594).
      
      As suggested by Ingo, allowing users with appropriate permissions seems an
      usable solution. We still need to define the "appropriate permissions".
      We can start with OFBTOOLS and WEBTOOLS, as it's reported by Ingo, and add
      others later if they ever come.
      
      Thanks: Ingo Wolfmayr for report and suggestion
      3de52be9
  15. 18 Apr, 2022 3 commits
  16. 16 Apr, 2022 1 commit
    • Giulio Speri's avatar
      Fixed: ecomm. listing ProductFacility out of stock issue (OFBIZ-12359) · bbc9e2fe
      Giulio Speri authored
      In method filterOutOfStockProducts added case for "virtual" products.
      In case a product isVirtual (= Y), then the available inventory count
      (lastInventoryCount) is summed up on all its product variants, across
      all the ProductFacility records, and then used to determine if the
      (parent/virtual) product is in stock or out of stock.
      
      This fix does not check if the facilityId of the ProductFacility
      records retrieved is associated and enabled to the ProductStore.
      
      Thanks Nicola Mazzoni for helping in anlyzing this issue.
      bbc9e2fe
  17. 14 Apr, 2022 2 commits
  18. 13 Apr, 2022 2 commits
    • Jacques Le Roux's avatar
      Fixed: Test run was unsuccessful because of failing solr tests (OFBIZ-12595) · da45698d
      Jacques Le Roux authored
      The previous commit for OFBIZ-12594 was only working on Windows. On *nix OSs
      there is no way to reliably get "--test" String from java.class.path property.
      
      Also the previous fix was brittle because relying only on 1 space separating
      words.
      
      This fix puts in the SolrDispatchFilter system property at the beginning of the
      4 Solr tests and removes it at end of them. That presence can reliably be tested
      in ControlFilter that is called before SolrDispatchFilter. It allows to bypass
      SecurityUtil::containsFreemarkerInterpolation that would else change the
      parameters content type that must be application/x-www-form-urlencoded.
      content
      
      Thanks: Tom Pietsch for report and Mart Naum for confirmation
      da45698d
    • Jacques Le Roux's avatar
  19. 09 Apr, 2022 1 commit
  20. 07 Apr, 2022 3 commits
    • Giulio Speri's avatar
      Fixed: inv. reservation places order if not enough qty (OFBIZ-12455) · 08cd4d01
      Giulio Speri authored
      If quantity not reserved is not 0, requireInventory is set to Y, system
      let an order to be placed anyway.
      
      The usage of the service around the project let make an important
      assertion: we can consider that also reserveInventory flag of the
      ProductStore is Y, since right now is always the caller context that
      checks for the reserveInventory flag.
      
      This fix simply returns a specific error to the caller, avoiding the
      system to place the order.
      
      Thanks Nicola Mazzoni for helping in debug this issue and Jacopo
      Cappellato for the patch review.
      08cd4d01
    • Jacques Le Roux's avatar
      Improved: Use NPM with gradle to get external JS dependencies (OFBIZ-11960) · b063216c
      Jacques Le Roux authored
      Puts the Uglify script in package.json with an example of use for jquery.flot.js
      
      The size diff between jquery.flot.js and jquery.flot.min.js is only 2%, so it's
      more an example...
      
      Note: to run the Uglify task alone use "gradlew npm_run_uglify"
      b063216c
    • Jacques Le Roux's avatar
      Revert "Revert "Tested: INFRA-23076"" · 6b44e972
      Jacques Le Roux authored
      This reverts commit 6c1265ca.
      Was not the last...
      6b44e972