1. 14 Aug, 2019 1 commit
  2. 13 Aug, 2019 1 commit
  3. 12 Aug, 2019 3 commits
  4. 11 Aug, 2019 2 commits
  5. 10 Aug, 2019 2 commits
  6. 09 Aug, 2019 2 commits
    • Nicolas Malin's avatar
      Implemented: Homogenize displaying number with multiple format · b20fc3ac
      Nicolas Malin authored
      (OFBIZ-7532)
      
      To display a number we had different possibilities :
       * on ftl use the template <@ofbizAmount and <@ofbizCurrency
       * by java call a function UtilFormatOut.formatAmount, UtilFormatOut.formatPrice, UtilFormatOut.formatQuantity, etc..
       * by form widget, use <display type=accounting-number for accounting but nothing for other
      
      To simplify and homogenize all, I implemented a number type purpose :
         * default: display a number by default, use when no purpose is present
         * quantity: display a number as a quantity
         * amount: display a number as an amount (like price without currency)
         * spelled: litteral displaying for a number (use on <@ofbizAmount ftl only before)
         * percentage: display a number as a percentage
         * accounting: diplay a number for accounting specific
      
      Each purpose can be associate to a number for displaying it :
         * on ftl <@ofbizNumber number=value format=purpose/>
         * on java UtilFormatOut.formatNumber(value, purpose, delegator, locale)
         * on form widget <display type=number format=purpose/>
      
      The format use by a purpose is define on framework/common/config/number.properties with the template
          .displaying.format = ##0.00
      
      With this, you can surchage a configuration, create your own purpose or surchage only one through entity SystemProperty.
      
      Concerning the backware compatibility: 
       * For the ftl the template <@ofbizAmount is now a link to '<@ofbizNumber format=amount'
       * For java all previous function call UtilFormatOut.formatNumber with the matching purpose
       * For form xml accounting-number is managed as an exection
      
      Last point, display a currency is different that a number, so I didn't refactoring some code for this case (only move properties from general to number for centralize de configuration on the same file)
      
      Thanks Charles Steltzlen to start the refactoring
      
      git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1864832 13f79535-47bb-0310-9956-ffa450edef68
      b20fc3ac
    • Nicolas Malin's avatar
      Implemented: Helper script to download the gradle wrapper · a47ab1ea
      Nicolas Malin authored
      (OFBIZ-10145)
      Add a helper script to download gradle-wrapper.jar and gradle-wrapper.properties 
      at version 5.0.0 from bintray [1] when gradle/wrapper/gradle-wrapper.jar isn't present.
      
      To use it just run at the OFBiz root :
          $ sh gradle/init-gradle-wrapper.sh
      
      [1] https://dl.bintray.com/apacheofbiz/GradleWrapper/
      [2] https://github.com/gradle/gradle/blob/v5.0.0/gradle/wrapper/
      
      git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1864815 13f79535-47bb-0310-9956-ffa450edef68
      a47ab1ea
  7. 08 Aug, 2019 2 commits
  8. 02 Aug, 2019 2 commits
  9. 29 Jul, 2019 2 commits
  10. 27 Jul, 2019 3 commits
  11. 24 Jul, 2019 1 commit
    • Nicolas Malin's avatar
      Fixed: EntityCondition(EntityOperator, fields...) raise exception with a null value · e310ca16
      Nicolas Malin authored
      (OFBIZ-11143)
      
      When you write an entity condition like
        rawProdcuts = from(Product).where(
          EntityCondition.makeCondition(EntityOperator.AND,
             'productTypeId', 'RAW_MATERIAL',
             'quantityUomId', null)
          ).queryList()
      
      the function
      
        public static EntityFieldMap makeCondition(EntityJoinOperator joinOp, Object... keysValues) 
      
      raise a IllegalArgumentException
      
      The problem came from EntityUtil.makeFields(V... args) (EntityUtil.java:65) who check if a value is an insteance of Comparable and Serializable but didn't take the case tat where have a null value.
      
      Thanks to Pawan Verma for the review
      
      git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863685 13f79535-47bb-0310-9956-ffa450edef68
      e310ca16
  12. 22 Jul, 2019 1 commit
    • Jacques Le Roux's avatar
      Fixed: Unknown request [images]; this request does not exist or cannot be · 96e3ada9
      Jacques Le Roux authored
      called directly.
      (OFBIZ-10895)
      
      Today Olivier reported directly to me that there was an issue in HR:
      <<If you go to humanres, at the level of the tree that appears the icons to expand 
      the tree no longer appear (but you can click...)
      This is due to the path of the d.png image which is wrong in the css file 
      (there is too much image in the path)>>
      
      I should have seen it because the d.png file is, with other related image files,
      in the same directory than style.css. And there was an inconsistency in the
      style.css files regarding the d.png file path.
      
      We should note that we have still this error in log:
      2019-07-22 16:25:26,275 |jsse-nio-8443-exec-7 |ControlServlet                
      |E| Error in request handler:
      org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request [d.png]; 
      this request does not exist or cannot be called directly.
      at org.apache.ofbiz.webapp.control.RequestHandler.doRequest
      (RequestHandler.java:277) ~[ofbiz.jar:?]
      
      As I wrote in my last commit for OFBIZ-10895:
      The only safe way to go is to not only check the error log for 
      "Unknown request [...."
      but also to look for 404 in access log, not all request show erroneously in
      error log.
      
      Some error appears before the user is logged in, as I wrote in the Jira:
      <<I noticed that this error message often appears before login. A 404 can be 
      seen in the access log and then once logged the issue no longer exists 
      (ie we get a 200). I have no yet investigated why...>>
      
      Nevertheless, I want to remove this misleading error message. I hope I'll do 
      that before forgetting.
      
      Thanks: Olivier Heintz 
      
      git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1863560 13f79535-47bb-0310-9956-ffa450edef68
      96e3ada9
  13. 20 Jul, 2019 17 commits
  14. 19 Jul, 2019 1 commit