Skip to content
  • Taher A. Alkhateeb's avatar
    Improved: Refactor and simplify the startup sequence in OFBiz · 92c8331e
    Taher A. Alkhateeb authored
    (OFBIZ-8337)
    
    This is a major refactoring exercise to simplify the startup sequence in
    OFBiz. There are no functional changes, however, both the logic and the
    API signatures of the core classes in OFBiz are changed to help simplify
    the startup sequence. The changes insofar are summarized as:
    
    - Rename ContainerConfig.Container to ContainerConfig.Configuration, the old
      nameing was very confusing as it confuses it with actual containers
    - Change the signature of ContainerLoader and Container to accept
      List<StartupCommand> instead of String[]. And also migrate the adapter for
      converting these args into a standalone class called
      StartupCommandsToArgsAdapter
    - Remove the LockedBy annotation as it is not used
    - Substantially simplify the ContainerLoader load and unload logic and delete
      the start logic (merge it with load). The interface StartupLoader was updated
      accordingly
    - Remove old logic to load containers in hot-deploy components
    - Remove printThreadDump output from ContainerLoader which used to exist for
      debugging purposes and is no longer necessary
    - Cleanup the AdminServer startup logic
    - Change the StartupControlPanel logic to use only one StartupLoader instead
      of a list. The only implementation is ContainerLoader
    - Remove the synchronized blocks in StartupControlPanel due to having only one
      loader
    - Update the startup .properties files to reflect the changes in the startup
      logic
    - Update the TestRunContainer to use List<StartupCommand> in its logic
    
    We expect more commits (specifically to the containers) to complete this
    refactoring initiative
    
    
    
    git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765127 13f79535-47bb-0310-9956-ffa450edef68
    92c8331e