1. 21 Jan, 2021 2 commits
  2. 18 Jan, 2021 2 commits
    • Jacques Le Roux's avatar
      Fixed: Terms are not shown correctly on the Invoice overview (OFBIZ-12139) · bee1b118
      Jacques Le Roux authored
      When we have multiple Payment (Net Days) terms on the invoice say
      20% in 15Days (FIN_PAY_NETDAYS_1)
      80% in 30Days (FIN_PAY_NETDAYS_2)
      
      The terms section shows incorrect term data as shown in the screenshot.
      
      Thanks: Nameet Jain for report and fix, Jacopo for confirmation
      bee1b118
    • Jacques Le Roux's avatar
      Fixed: Creating a new Customer create a wrong record in CommunicationEvent (OFBIZ-12142) · 20e7fc54
      Jacques Le Roux authored
      In https://markmail.org/message/pf3d3qyjfucicbj7 I initially answered:
      In demo data 13 parties use <<infoString="ofbiztest@example.com">> as in
      <ContactMech contactMechId="FRA01" contactMechTypeId="EMAIL_ADDRESS" infoString="ofbiztest@example.com"/>
      This one is loaded last. Rather
      <ContactMech contactMechId="Company" contactMechTypeId="EMAIL_ADDRESS" infoString="ofbiztest@example.com"/>
      which is the 1st one, should be loaded last.
      
      A better solution is to use "ofbizsupport@example.com" in EmailServices.xml
      
      Indeed, fortunately the Company party also uses this infoString and using it in
      EmailServices.xml does not affect the integration test and should not affect
      other parts of the (only) demo data
      
      Thanks: Emad Radwan for opiniated report :) and Pritam Kute for issue analysis
      20e7fc54
  3. 16 Jan, 2021 1 commit
  4. 15 Jan, 2021 2 commits
    • Eugen Stan's avatar
      Improved: Add extra classpath directories for ofbiz.tar/zip · cc76b990
      Eugen Stan authored
      (OFBIZ-12136)
      
      Allows people to add configuration files and jars (database drivers) when
      using the binary distribution.
      
      Thanks: Eugen Stan for improvement
      cc76b990
    • Nicolas Malin's avatar
      Implemented: Add a framework method to get main webapp menu with the webapp name · 71657682
      Nicolas Malin authored
      (OFBIZ-10601)
      
      To improve theme management and provide better tools for new themes, we implement a method to obtain the main menu of a webapp.
      Instead of just managing a menu, we extend the functionality by offering a method to expose a summary of the webapp, to simplify the navigation.
      
      For this we add a new attribute on webapp definition app-shortcut-screen :
      
          <webapp name="mywebapp"
                  ...
                  app-shortcut-screen="component://mycomponent/widget/CommonScreens.xml#ShortcutApp"
                  ...
          />
      
      The idea is to define a new purpose screen *Shortcut* that contains what defines a webapp when an action or navigation has been requested. With this screen you can load a menu, a search, a complex description and use all screen powerfulness to resolve what displaying and support by theming
      
          <screen name="ShortcutApp">
              <section>
                  <actions>
                      <property-map resource="CommonUiLabels" map-name="uiLabelMap" global="true"/>
                  </actions>
                  <widgets>
                      <decorator-screen name="ShortcutDecorator" location="component://common/widget/CommonScreens.xml">
                          <decorator-section name="body">
                              <include-menu name="MyShortcutAppBar" location="component://mycomponent/widget/CommonMenus.xml"/>
                          </decorator-section>
                      </decorator-screen>
                  </widgets>
              </section>
          </screen>
      
      Each component are self-sufficient to define what shortcuts to display without framework change or knowledge about other component.
      Each theme can implement and customize the display rendering at will.
      
      To illustrate an example of implementation we set sub menu for each webapp defined on applications and exploit it on bluelight theme.
      
      Thanks for Dennis Balkir, Jacques Leroux, Leila Mekika and Julien Nicolas for their involvement
      71657682
  5. 14 Jan, 2021 3 commits
  6. 13 Jan, 2021 3 commits
  7. 12 Jan, 2021 5 commits
    • Nicolas Malin's avatar
      Implemented: Access to the current screen from any widget element · e0a840a0
      Nicolas Malin authored
      (OFBIZ-11809)
      
      During the rendering process, an element have no information about the screen which is dependent from. This not really help to automate some refresh treatment and force the developer to know the screen structure where is the element.
      
      To solve this situation we implement a new class, ScreenStack that allow anytime for any element to identify its direct dependency. This help to resolve the unique Id that the screen take and can be used by the theme.
      
      At any time a developer can retrieve the screen reference with uel function screen:id(screenStack)
      
      example:
           <container id="${screen:id(screenStack)}">
      
      The object screenStack is always present during a rendering process.
      e0a840a0
    • James Yong's avatar
      Refactoring · 3c83ab53
      James Yong authored
      3c83ab53
    • Daniel Watford's avatar
      Improved: MacroFormRenderer refactoring of label, display and text · 3795727e
      Daniel Watford authored
      fields
      
      (OFBIZ-11900)
      
      New RenderableFtl elements to represent pre-rendered FTL strings and FTL
      macro calls. RenderableFtl elements are able to render themselves to
      strings which are processed as an FTL template by the FtlWriter class.
      
      For labels, display fields and text fields, MacroFormRenderer no longer
      generates FTL to write to a template itself, but instead calls
      RenderableFtlFormElementsBuilder to create corresponding RenderableFtl
      elements which are then processed by FtlWriter. This is a WIP to reduce
      complexity in MacroFormRenderer.
      3795727e
    • James Yong's avatar
      Fixed: Incorrect date format in tooltip (OFBIZ-12123) · d32814e5
      James Yong authored
      Tooltip should show the date format used by the picker.
      d32814e5
    • James Yong's avatar
      Fixed: Date picker not initialised in ajax-called form (OFBIZ-12097) · 25adbd20
      James Yong authored
      Fixed regression. Manual entry is cleared after moving to next field.
      
      Thanks: Olivier for reporting
      25adbd20
  8. 11 Jan, 2021 1 commit
    • Daniel Watford's avatar
      Fixed: Issue starting ofbiz from tar distribution (OFBIZ-12118) · c9ee8421
      Daniel Watford authored
      Avoid using caches when opening a URL connection to read an XML resource
      in a JAR file.
      
      If caches were used when running from the ofbiz.jar file then attempts
      to read resources from the jar would fail due to the cached file's
      InputStream already being in a closed state.
      
      Thanks: Eugen Stan for the bug report and fix.
      c9ee8421
  9. 09 Jan, 2021 2 commits
  10. 06 Jan, 2021 1 commit
  11. 03 Jan, 2021 1 commit
  12. 02 Jan, 2021 2 commits
  13. 01 Jan, 2021 1 commit
  14. 29 Dec, 2020 1 commit
    • Jacques Le Roux's avatar
      Improved: Create 'New Communication' button should be removed from create new... · 66decd89
      Jacques Le Roux authored
      Improved: Create 'New Communication' button should be removed from create new communication screen. (OFBIZ-12027)
      
      Steps to replicate the issue :
      Go to Party application.
      On the 'find communications' screen clicks on the 'New communications' button.
      The system will navigate you to create/edit communications screen.
      On create/edit communications screen you will see the 'New communications' button.
      
      Providing the 'New communications' button on the 'create new communication
      screen' does not make any sense over so it should be removed from here.
      
      Thanks: Shubham Choudhary
      66decd89
  15. 27 Dec, 2020 1 commit
  16. 26 Dec, 2020 4 commits
  17. 25 Dec, 2020 4 commits
    • Jacques Le Roux's avatar
      Improved: Remove hardcoded product category on CategoryWorker.getCatalogTopCategory (OFBIZ-12078) · 0fc14af6
      Jacques Le Roux authored
      When you call the java function
      org.apache.ofbiz.product.category.CategoryWorker.getCatalogTopCategory()
      the catalog returned if the system failed found it is hardcoded and don't use an
      existing property : catalog->top.category.default
      
      Thanks: Nicolas
      0fc14af6
    • Jacques Le Roux's avatar
      Fixed: Unique form names for promo actions (OFBIZ-12082) · 6110ced9
      Jacques Le Roux authored
      Creating a promo with multiple rules and actions results in an exception.
      
      It's reproducible by creating a promo with 1 rule and more than 1 Action and
      specifying different products for each Action. When creating the second Action
      and trying to specify another product to included the ajax request LookupProduct
      will fail because it included both product ids in its xhr request.
      
      Thanks: Danny Trunk
      6110ced9
    • Jacques Le Roux's avatar
      Fixed: Issue in creating promotion action (OFBIZ-11168) · 3cdd1fce
      Jacques Le Roux authored
      The issue reported there was fixed with OFBIZ-11058.
      
      But there was still an issue in logI reported in a comment.
      
      The problem was that
      <#assign productPromoActionCurEnum = productPromoAction.getRelatedOne("ActionEnumeration", true)>
      was used in 2 places where it should not have been because it returned a null
      value that can't be handled by OFBiz.
      
      Better use
      <#assign productPromoActionCustomMethod = productPromoAction.getRelatedOne("CustomMethod", true)>
      and
      productPromoAction.getRelatedOne("ActionEnumeration", true))??
      
      The repercussion was that the description was not used but the Id and the log
      was showing an error.
      3cdd1fce
    • Jacques Le Roux's avatar
      Documented: why not upgrading org.jdom:jdom:1.1.3 · 1cc035db
      Jacques Le Roux authored
      Better comment
      1cc035db
  18. 21 Dec, 2020 1 commit
  19. 20 Dec, 2020 3 commits