- 21 Jan, 2021 2 commits
-
-
James Yong authored
-
James Yong authored
Allow application to define event messages that contain javascripts, via request attribute "_UNSAFE_EVENT_MESSAGE_" Thanks Jacques for review
-
- 18 Jan, 2021 2 commits
-
-
Jacques Le Roux authored
When we have multiple Payment (Net Days) terms on the invoice say 20% in 15Days (FIN_PAY_NETDAYS_1) 80% in 30Days (FIN_PAY_NETDAYS_2) The terms section shows incorrect term data as shown in the screenshot. Thanks: Nameet Jain for report and fix, Jacopo for confirmation
-
Jacques Le Roux authored
In https://markmail.org/message/pf3d3qyjfucicbj7 I initially answered: In demo data 13 parties use <<infoString="ofbiztest@example.com">> as in <ContactMech contactMechId="FRA01" contactMechTypeId="EMAIL_ADDRESS" infoString="ofbiztest@example.com"/> This one is loaded last. Rather <ContactMech contactMechId="Company" contactMechTypeId="EMAIL_ADDRESS" infoString="ofbiztest@example.com"/> which is the 1st one, should be loaded last. A better solution is to use "ofbizsupport@example.com" in EmailServices.xml Indeed, fortunately the Company party also uses this infoString and using it in EmailServices.xml does not affect the integration test and should not affect other parts of the (only) demo data Thanks: Emad Radwan for opiniated report :) and Pritam Kute for issue analysis
-
- 16 Jan, 2021 1 commit
-
-
Jacques Le Roux authored
Upcoming Branch is actually another name for trunk. It's always evolving and never released. Better put a date when deprecating a Class or method. Else you have no idea when it was deprecated, apart referring to git-blame.
-
- 15 Jan, 2021 2 commits
-
-
Eugen Stan authored
(OFBIZ-12136) Allows people to add configuration files and jars (database drivers) when using the binary distribution. Thanks: Eugen Stan for improvement
-
Nicolas Malin authored
(OFBIZ-10601) To improve theme management and provide better tools for new themes, we implement a method to obtain the main menu of a webapp. Instead of just managing a menu, we extend the functionality by offering a method to expose a summary of the webapp, to simplify the navigation. For this we add a new attribute on webapp definition app-shortcut-screen : <webapp name="mywebapp" ... app-shortcut-screen="component://mycomponent/widget/CommonScreens.xml#ShortcutApp" ... /> The idea is to define a new purpose screen *Shortcut* that contains what defines a webapp when an action or navigation has been requested. With this screen you can load a menu, a search, a complex description and use all screen powerfulness to resolve what displaying and support by theming <screen name="ShortcutApp"> <section> <actions> <property-map resource="CommonUiLabels" map-name="uiLabelMap" global="true"/> </actions> <widgets> <decorator-screen name="ShortcutDecorator" location="component://common/widget/CommonScreens.xml"> <decorator-section name="body"> <include-menu name="MyShortcutAppBar" location="component://mycomponent/widget/CommonMenus.xml"/> </decorator-section> </decorator-screen> </widgets> </section> </screen> Each component are self-sufficient to define what shortcuts to display without framework change or knowledge about other component. Each theme can implement and customize the display rendering at will. To illustrate an example of implementation we set sub menu for each webapp defined on applications and exploit it on bluelight theme. Thanks for Dennis Balkir, Jacques Leroux, Leila Mekika and Julien Nicolas for their involvement
-
- 14 Jan, 2021 3 commits
-
-
Daniel Watford authored
String (OFBIZ-10710) Thanks: Benjamin Jugl for report and patch.
-
Daniel Watford authored
(OFBIZ-11927)
-
Daniel Watford authored
(OFBIZ-12137) Prevents logging of deprecation warnings during the build.
-
- 13 Jan, 2021 3 commits
-
-
Jacques Le Roux authored
Thanks: Daniel
-
Daniel Watford authored
-
James Yong authored
Rename + Refactor
-
- 12 Jan, 2021 5 commits
-
-
Nicolas Malin authored
(OFBIZ-11809) During the rendering process, an element have no information about the screen which is dependent from. This not really help to automate some refresh treatment and force the developer to know the screen structure where is the element. To solve this situation we implement a new class, ScreenStack that allow anytime for any element to identify its direct dependency. This help to resolve the unique Id that the screen take and can be used by the theme. At any time a developer can retrieve the screen reference with uel function screen:id(screenStack) example: <container id="${screen:id(screenStack)}"> The object screenStack is always present during a rendering process.
-
James Yong authored
-
Daniel Watford authored
fields (OFBIZ-11900) New RenderableFtl elements to represent pre-rendered FTL strings and FTL macro calls. RenderableFtl elements are able to render themselves to strings which are processed as an FTL template by the FtlWriter class. For labels, display fields and text fields, MacroFormRenderer no longer generates FTL to write to a template itself, but instead calls RenderableFtlFormElementsBuilder to create corresponding RenderableFtl elements which are then processed by FtlWriter. This is a WIP to reduce complexity in MacroFormRenderer.
-
James Yong authored
Tooltip should show the date format used by the picker.
-
James Yong authored
Fixed regression. Manual entry is cleared after moving to next field. Thanks: Olivier for reporting
-
- 11 Jan, 2021 1 commit
-
-
Daniel Watford authored
Avoid using caches when opening a URL connection to read an XML resource in a JAR file. If caches were used when running from the ofbiz.jar file then attempts to read resources from the jar would fail due to the cached file's InputStream already being in a closed state. Thanks: Eugen Stan for the bug report and fix.
-
- 09 Jan, 2021 2 commits
-
-
Suraj Khurana authored
(OFBIZ-11901) Thanks Ravi Lodhi for review and discussion.
-
James Yong authored
User can open menu definition file from the browser by clicking on the named border.
-
- 06 Jan, 2021 1 commit
-
-
James Yong authored
Fix named borders not rendered for sub-screens.
-
- 03 Jan, 2021 1 commit
-
-
James Yong authored
Improve naming
-
- 02 Jan, 2021 2 commits
-
-
Jacques Le Roux authored
-
James Yong authored
Apply CSS Grid Layout on the form. Keep related fields together
-
- 01 Jan, 2021 1 commit
-
-
James Yong authored
Test pages at /ordermgr/control/FindRequest and /ordermgr/control/findorders
-
- 29 Dec, 2020 1 commit
-
-
Jacques Le Roux authored
Improved: Create 'New Communication' button should be removed from create new communication screen. (OFBIZ-12027) Steps to replicate the issue : Go to Party application. On the 'find communications' screen clicks on the 'New communications' button. The system will navigate you to create/edit communications screen. On create/edit communications screen you will see the 'New communications' button. Providing the 'New communications' button on the 'create new communication screen' does not make any sense over so it should be removed from here. Thanks: Shubham Choudhary
-
- 27 Dec, 2020 1 commit
-
-
James Yong authored
Links not showing correctly for themes like Bluelight, Tomahawk. This reverts commit 9d0e5313
-
- 26 Dec, 2020 4 commits
-
-
James Yong authored
For Order application
-
James Yong authored
Extend the same behavior to SetMultipleSelectJs.ftl.
-
Jacques Le Roux authored
This is a bug due to OFBIZ-12080, fileToCheck is the complete name of the file with path not the filename Thanks: Wai for report
-
James Yong authored
Changed at SetMultipleSelectJsList.ftl. Tested page at /ordermgr/control/FindRequest
-
- 25 Dec, 2020 4 commits
-
-
Jacques Le Roux authored
When you call the java function org.apache.ofbiz.product.category.CategoryWorker.getCatalogTopCategory() the catalog returned if the system failed found it is hardcoded and don't use an existing property : catalog->top.category.default Thanks: Nicolas
-
Jacques Le Roux authored
Creating a promo with multiple rules and actions results in an exception. It's reproducible by creating a promo with 1 rule and more than 1 Action and specifying different products for each Action. When creating the second Action and trying to specify another product to included the ajax request LookupProduct will fail because it included both product ids in its xhr request. Thanks: Danny Trunk
-
Jacques Le Roux authored
The issue reported there was fixed with OFBIZ-11058. But there was still an issue in logI reported in a comment. The problem was that <#assign productPromoActionCurEnum = productPromoAction.getRelatedOne("ActionEnumeration", true)> was used in 2 places where it should not have been because it returned a null value that can't be handled by OFBiz. Better use <#assign productPromoActionCustomMethod = productPromoAction.getRelatedOne("CustomMethod", true)> and productPromoAction.getRelatedOne("ActionEnumeration", true))?? The repercussion was that the description was not used but the Id and the log was showing an error.
-
Jacques Le Roux authored
Better comment
-
- 21 Dec, 2020 1 commit
-
-
James Yong authored
Use square interpolation syntax when file extension is .spi.ftl
-
- 20 Dec, 2020 3 commits
-
-
Jacques Le Roux authored
-
Jacques Le Roux authored
Forget about upgrading org.jdom to v2 we need only JDOMException and it works as is. So this reverts to org.jdom to v1. We still need the updated entry in build.gradle This fixes integration tests with framework only
-
Jacques Le Roux authored
I noticed an issue due to entity-auto. Unlike with a standard service you can't protect fields using allow-html="safe" except by overriding fields. So in case this must be done one by one... An example is ruleName field in PriceForms.xml#AddPriceRules with createProductPriceRule and updateProductPriceRule services This fixes this only case... Also removes trailing blanks and only that (by IDE setting)
-